Skip to content

fix(screencast): keep overlays above top layer elements - #42642

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:fix-42629
Sep 9, 2026
Merged

fix(screencast): keep overlays above top layer elements#42642
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:fix-42629

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • Re-promote the glass pane into the top layer on every highlight use, so overlays shown after a dialog or popover opened paint above it.
  • While user overlays are showing, keep re-promoting the pane on a timer, so dialogs and popovers opened later do not cover it.

Fixes #42629

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`

51452 passed, 1246 skipped


Merge workflow run.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the failures are pre-existing firefox flakes

Hi, I'm the Playwright bot and I took a first look at the failing CI.

Nothing here looks caused by this PR. The tests 1 report has no real failures (9 flaky, all rescued on retry). The only reds are 4 firefox MCP tests, and every one of them has a long history of flaking on unrelated SHAs and PRs — including main pushes — well before this branch. This PR only touches the injected highlight/overlay glass pane (highlight.ts, injectedScript.ts) and its screencast-overlay test; it doesn't go near the MCP http transport, annotate CDP path, or the devtools CLI part-extraction those tests exercise.

Details

Overall: worst per-group call is green. The 4 MCP failures are all firefox-only, all bimodal (pass the overwhelming majority of runs), and all fail on many SHAs this PR can't be responsible for.

Pre-existing flake / infra

The overlay change here is Chromium/screencast-facing and lives entirely in the glass-pane promotion logic; the annotate flow uses highlights but fails on firefox independent of this diff, so the connection is coincidental, not causal.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 47c35ea into microsoft:main Sep 9, 2026
56 of 58 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8348 passed, 1376 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI]: Screencast showOverlay/showChapter is invisible behind any top-layer element (dialog/popover) — the #39123 fix doesn't cover this path

2 participants