Fixing telemetry message format

[Vidal Ortega (vidorteg)]

The new pipeline for ingesting telemetry expects it in a specific format, so moving the data to it.

[Copilot]

🟡 Changes recommended

Critical error-event and retail-path test issues remain, along with a taxonomy collision issue.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Migrates telemetry to the new area/feature/action/outcome taxonomy and normalizes event names for ingestion.

Changes:

• Adds shared taxonomy helpers and updates telemetry call sites.
• Adds Aria event-name sanitization.
• Updates related production code and tests.

File summaries

File	Summary	Review notes
test/utils.test.ts	Updates utility telemetry expectations.	—
test/telemetryTaxonomy.test.ts	Tests taxonomy formatting and dispatch.	—
test/extension.test.ts	Updates extension telemetry expectations.	—
test/devtoolsPanel.test.ts	Updates DevTools telemetry expectations.	—
test/ariaTelemetryReporter.test.ts	Tests event-name sanitization.	—
src/utils.ts	Migrates utility telemetry events.	—
src/telemetryTaxonomy.ts	Defines taxonomy dimensions and sending helpers.	Moderate (1 vote): Caller properties can override fixed taxonomy dimensions; keep dimensions last and add a collision test.
src/screencastPanel.ts	Migrates screencast telemetry.	—
src/launchDebugProvider.ts	Migrates debug telemetry.	—
src/extension.ts	Migrates extension command and error telemetry.	—
src/devtoolsPanel.ts	Migrates DevTools telemetry.	—
src/cdpTargetsProvider.ts	Migrates target-list telemetry.	—
src/ariaTelemetryReporter.ts	Sanitizes telemetry event names.	Critical (1 vote): sendErrorData is not sanitized, so error events may be dropped. Critical (1 vote): The existing retail-path test fails because the mock returns a plain object; update the mock/expectation for the derived class.

Review details

Suppressed comments (1)

src/telemetryTaxonomy.ts:53

• The event-specific spread comes after the taxonomy dimensions, so any caller-supplied area, feature, action, outcome, or detail silently replaces the fixed taxonomy. This also lets sendTaxonomyErrorEvent report outcome: 'success' if its properties contain an outcome key. Keep the dimensions last (and add a collision test) so the event name and properties cannot disagree.

    return { ...dimensions, ...properties };

• Files reviewed: 13/13 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.