Adding npm_config_registry to ESRPSign - #5004
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Vidal Ortega (vidorteg)
September 11, 2026 21:58
View session
There was a problem hiding this comment.
🔵 Needs a closer look
The registry override does not cover dependency URLs pinned in package-lock.json.
Pull request overview
Adds a configurable npm registry override to the ESRPSign pipeline.
Changes:
- Defines
npm_config_registryusingNpmRegistry. - Defaults to
https://registry.npmjs.org/.
File summaries
| File | Summary |
|---|---|
.github/workflows/ESRPSign.yml |
Adds npm registry configuration; dependency URLs pinned in package-lock.json may still bypass the override. |
Review details
Suppressed comments (1)
.github/workflows/ESRPSign.yml:22
- This variable does not make the registry override effective for the install as written:
npm ciconsumes the tarball URLs pinned inpackage-lock.json, and this lockfile's resolved entries point tohttps://registry.npmjs.org/. WhenNpmRegistryis set to another feed, the install can still fetch those URLs directly (or fail if the public registry is unavailable), so the override does not cover the dependencies being installed. The lockfile/install flow needs to rewrite or resolve those URLs against the selected registry as well.
npm_config_registry: $[coalesce(variables['NpmRegistry'], 'https://registry.npmjs.org/')]
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ElormCoch
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding npm_config_registry to ESRPSign pipeline, so that an override can be specified