Repository navigation
API: Query capabilities - #1936
Open
Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Open
Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Conversation
Eduardo Villalpando Mello (edvilme)
marked this pull request as ready for review
October 17, 2026 02:31
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Concurrent probes introduce uncached version subprocesses whose runtime impact needs mitigation and validation beyond mocked tests.
1 open issue
What changed in this PR
Adds observational capability queries to public environment and package operations, supporting API 2.0 diagnostics without gating execution.
Changes:
- Maps operations to non-blocking capability queries.
- Adds mapping and failure-isolation tests.
- Documents query behavior and fixture requirements.
| File | Description |
|---|---|
| src/test/internal/publicApiCompatibility.unit.test.ts | Uses internal manager wrappers and isolates version telemetry. |
| src/test/extensionApi.unit.test.ts | Tests capability mapping and operation isolation. |
| src/extensionApi.ts | Initiates capability queries before manager operations. |
| docs/README.md | Documents observational query behavior. |
| .github/instructions/testing-workflow.instructions.md | Adds guidance for capability-aware test fixtures. |
Review effort: Balanced
Comment on lines
+542
to
+543
| void this.getPackageManagerCapability(context, PackageCapability.List, manager.project) | ||
| .catch(logCapabilityQueryError); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1837
This pull request enhances the Python environment and package management APIs by adding observational capability queries before executing most public operations. These queries help track and log the capabilities of managers without blocking or affecting the actual operations, improving telemetry and diagnostics.
API Enhancements for Capability Queries:
getEnvironmentManagerCapabilityandgetPackageManagerCapability) before delegating to managers. These queries are non-blocking, and failures are logged without impacting the operation's outcome. This applies to actions like create, remove, refresh, set/get selected environment, and package management operations.