Skip to content

Apply better-regex lint fixes#2814

Open
ConnorQi01 wants to merge 1 commit into
masterfrom
dev/v-peq/better_regex_lint_fixes
Open

Apply better-regex lint fixes#2814
ConnorQi01 wants to merge 1 commit into
masterfrom
dev/v-peq/better_regex_lint_fixes

Conversation

@ConnorQi01

Copy link
Copy Markdown
Collaborator

Summary

Apply two better-regex lint recommendations without changing validation behavior.

Proposed Changes

  • Simplify the filepath validation character class in androidContainerUtility.
  • Simplify the version validation digit classes in installExpoGoApplication.
  • Remove the corresponding better-regex and unnecessary escape warnings.

Test Plan

  • npx prettier --check src\extension\android\androidContainerUtility.ts src\extension\commands\installExpoGoApplication.ts
  • npm run build
  • npm test - fails in the existing rn-extension commandsRegistered assertion because reactNative.publishToExpHost is present in the runtime command list but absent from the expected list.

Closes #2813

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Apply better-regex lint fixes

1 participant