Support new TS extension ID in addition to old ID#321192
Open
jakebailey wants to merge 3 commits into
Open
Conversation
Member
Author
|
FYI @mjbvz |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates TypeScript Go / native preview extension detection so the extension can be recognized under multiple extension IDs.
Changes:
- Introduce
getTsNativeExtension()andtsNativeExtensionIdsto resolve the installed extension across multiple IDs. - Update existing checks to use
getTsNativeExtension()instead ofvscode.extensions.getExtension(...). - Generalize
requireHasVsCodeExtensionto accept multiple extension IDs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/typescript-language-features/src/ui/suggestNativePreview.ts | Switches native preview installed-check to getTsNativeExtension() |
| extensions/typescript-language-features/src/tsServer/versionManager.ts | Uses shared helper to detect native preview extension for quick pick |
| extensions/typescript-language-features/src/languageFeatures/util/dependentRegistration.ts | Extends extension-existence condition to support multiple IDs |
| extensions/typescript-language-features/src/extension.ts | Updates conditional registration to accept multiple native extension IDs |
| extensions/typescript-language-features/src/commands/useTsgo.ts | Adds multi-ID constants + getTsNativeExtension() and updates setting logic to use it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're moving to a new name. Make sure the TS extension understands that.
I did not update the code that is "suggesting" the native preview extension yet; keeping that is probably okay for now as we are going to auto-install the new name anyway to move users over.