Skip to content

Support new TS extension ID in addition to old ID#321192

Open
jakebailey wants to merge 3 commits into
microsoft:mainfrom
jakebailey:new-corsa-name
Open

Support new TS extension ID in addition to old ID#321192
jakebailey wants to merge 3 commits into
microsoft:mainfrom
jakebailey:new-corsa-name

Conversation

@jakebailey

Copy link
Copy Markdown
Member

We're moving to a new name. Make sure the TS extension understands that.

I did not update the code that is "suggesting" the native preview extension yet; keeping that is probably okay for now as we are going to auto-install the new name anyway to move users over.

Copilot AI review requested due to automatic review settings June 12, 2026 17:53
@jakebailey

Copy link
Copy Markdown
Member Author

FYI @mjbvz

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates TypeScript Go / native preview extension detection so the extension can be recognized under multiple extension IDs.

Changes:

  • Introduce getTsNativeExtension() and tsNativeExtensionIds to resolve the installed extension across multiple IDs.
  • Update existing checks to use getTsNativeExtension() instead of vscode.extensions.getExtension(...).
  • Generalize requireHasVsCodeExtension to accept multiple extension IDs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
extensions/typescript-language-features/src/ui/suggestNativePreview.ts Switches native preview installed-check to getTsNativeExtension()
extensions/typescript-language-features/src/tsServer/versionManager.ts Uses shared helper to detect native preview extension for quick pick
extensions/typescript-language-features/src/languageFeatures/util/dependentRegistration.ts Extends extension-existence condition to support multiple IDs
extensions/typescript-language-features/src/extension.ts Updates conditional registration to accept multiple native extension IDs
extensions/typescript-language-features/src/commands/useTsgo.ts Adds multi-ID constants + getTsNativeExtension() and updates setting logic to use it

Comment thread extensions/typescript-language-features/src/commands/useTsgo.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants