Fix compact application menu spacing - #334908
Open
Lee Murray (mrleemurray) wants to merge 5 commits into
Open
Conversation
Fixes #334615 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 7, 2026 12:41
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified in the reviewed changes.
Pull request overview
Fixes compact application-menu spacing while preserving activity-rail gaps.
Changes:
- Narrows activity-bar gap styling to exclude nested menus.
- Adds layout and density regression tests.
- Adds themed visual fixtures.
File summaries
| File | Description |
|---|---|
src/vs/workbench/test/browser/componentFixtures/activityBarMenu.fixture.ts |
Adds themed menu fixtures. |
src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts |
Tests rail and menu spacing. |
src/vs/workbench/browser/media/floatingPanels.css |
Narrows the rail-gap selector. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Added (6)
|
Giuseppe Cianci (Giuspepe)
previously approved these changes
Sep 7, 2026
Lee Murray (mrleemurray)
enabled auto-merge
September 7, 2026 17:11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alexandru Dima (alexdima)
approved these changes
Sep 7, 2026
Alexandru Dima (alexdima)
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334615
Summary
Keep activity-rail spacing out of nested compact application menus. The floating-rail margin selector also matched menu rows and separators, increasing normal 24px row steps to 32px at default density and 28px at compact density.
Validation
./scripts/test.sh \ --run src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts \ --run src/vs/workbench/test/browser/parts/activitybar/activitybarPart.test.ts \ --run src/vs/base/test/browser/ui/menu/menu.test.ts \ --run src/vs/base/test/browser/ui/menu/menubar.test.ts \ --grep "ActivitybarPart|^Menu|activity bar|floating rail|compact application menu"Manual verification
In the web workbench with Modern UI and the compact application menu in the activity bar, open Edit. Check normal row and separator spacing at default and compact density, then verify keyboard entry and dismissal. Repeat in light and high-contrast themes.
Menu placement and overflow reports #334616 and #334886 remain separate.
Screenshots
Captured from the same real-widget component fixture at default density, with Edit selected and Undo focused. The fix restores menu spacing without changing the rail gap.