Fix panel tab overlap when terminal title changes - #334927
Open
wynn (wynnsimon) wants to merge 1 commit into
Open
Fix panel tab overlap when terminal title changes#334927wynn (wynnsimon) wants to merge 1 commit into
wynn (wynnsimon) wants to merge 1 commit into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
Anthony Kim (@anthonykim1)Matched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334923
When the terminal title grows after changing directories in Modern UI, it can overlap the panel tabs because their available width is not recalculated.
This change forwards inline title content changes through the toolbar and schedules the existing panel layout on the next animation frame, without rebuilding toolbar items.
Verified with Modern UI and classic UI at narrow and wide widths. Added regression tests for change notifications and toolbar item preservation. Related tests, type checking, and lint pass.