layout: backport primary side bar width fix to 1.137 - #334952
Merged
Lee Murray (mrleemurray) merged 1 commit intoSep 8, 2026
Merged
Conversation
…debar-width-reset-on-toggle Fix primary side bar width reset when toggled with the side bar on the right
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 7, 2026 16:57
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The backport matches the original fix and includes focused regression coverage.
Pull request overview
Backports the primary side bar width fix from #334864 to release 1.137.
Changes:
- Redistributes split-view changes by layout priority.
- Adds regression coverage for right-side primary side bar toggling.
File summaries
| File | Description |
|---|---|
src/vs/base/browser/ui/splitview/splitview.ts |
Applies priority-aware relayout after constraint changes. |
src/vs/base/test/browser/ui/splitview/splitview.test.ts |
Tests width preservation during visibility toggles. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Lee Murray (mrleemurray)
enabled auto-merge
September 7, 2026 17:11
Ulugbek Abdullaev (ulugbekna)
approved these changes
Sep 8, 2026
Lee Murray (mrleemurray)
merged commit Sep 8, 2026
36e07af
into
microsoft:release/1.137
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #334864 to
release/1.137.Changes
Validation
npm run hygienenpm run transpile-client./scripts/test.sh --run src/vs/base/test/browser/ui/splitview/splitview.test.ts— 19 passingLocal environment notes
npm run compile-clientwas attempted but the worktree lacks the unrelated built-in extension dependency@vscode/markdown-editor.npm run typecheck-clientwas attempted but the worktree lacks the unrelated runtime type dependenciesoriginal-fsandelectron.