Skip to content

layout: backport primary side bar width fix to 1.137 - #334952

Merged
Lee Murray (mrleemurray) merged 1 commit into
microsoft:release/1.137from
mrleemurray:backport-334864-release-1.137
Sep 8, 2026
Merged

layout: backport primary side bar width fix to 1.137#334952
Lee Murray (mrleemurray) merged 1 commit into
microsoft:release/1.137from
mrleemurray:backport-334864-release-1.137

Conversation

@mrleemurray

Copy link
Copy Markdown
Contributor

Backports #334864 to release/1.137.

Changes

Validation

  • npm run hygiene
  • npm run transpile-client
  • ./scripts/test.sh --run src/vs/base/test/browser/ui/splitview/splitview.test.ts — 19 passing

Local environment notes

  • npm run compile-client was attempted but the worktree lacks the unrelated built-in extension dependency @vscode/markdown-editor.
  • npm run typecheck-client was attempted but the worktree lacks the unrelated runtime type dependencies original-fs and electron.

…debar-width-reset-on-toggle

Fix primary side bar width reset when toggled with the side bar on the right
Copilot AI balanced review requested due to automatic review settings September 7, 2026 16:57
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/base/browser/ui/splitview/splitview.ts

@mrleemurray Lee Murray (mrleemurray) added the release-cherry-pick Automated cherry-pick between release and main branches label Sep 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The backport matches the original fix and includes focused regression coverage.

Pull request overview

Backports the primary side bar width fix from #334864 to release 1.137.

Changes:

  • Redistributes split-view changes by layout priority.
  • Adds regression coverage for right-side primary side bar toggling.
File summaries
File Description
src/vs/base/browser/ui/splitview/splitview.ts Applies priority-aware relayout after constraint changes.
src/vs/base/test/browser/ui/splitview/splitview.test.ts Tests width preservation during visibility toggles.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mrleemurray
Lee Murray (mrleemurray) merged commit 36e07af into microsoft:release/1.137 Sep 8, 2026
30 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modernization release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants