Skip to content

Hide repository controls for new chats in a session - #334965

Open
Sandeep Somavarapu (sandy081) wants to merge 2 commits into
microsoft:mainfrom
sandy081:agents/new-chat-in-a-session-ui-should-not
Open

Hide repository controls for new chats in a session#334965
Sandeep Somavarapu (sandy081) wants to merge 2 commits into
microsoft:mainfrom
sandy081:agents/new-chat-in-a-session-ui-should-not

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

  • hide the worktree and branch configuration controls when composing a new chat inside an existing session
  • center the in-session composer to match the new-session UI
  • add regression coverage for suppressing repository controls

Validation

  • npm run compile
  • npm run hygiene
  • ./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/newChatInput.test.ts
  • npm run stylelint -- src/vs/sessions/contrib/chat/browser/media/newChatInSession.css

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 7, 2026 18:45
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.138.0 milestone Sep 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Attachment layout remains inconsistent when centered, and the test does not cover the host wiring.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 Medium severity

New issues introduced by this change (2)
Severity Finding
Medium severity src/​vs/​sessions/​contrib/​chat/​browser/​media/​newChatInSession.css — Centering this flex item exposes the attachment-offset path, but the in-session…
Medium severity src/​vs/​sessions/​contrib/​chat/​test/​browser/​newChatInput.test.ts — This exercises only the extracted helper, not the in-session host wiring. Removing…
What changed in this PR

Hides repository controls and centers the composer for new chats within existing sessions.

Changes:

  • Adds an option to suppress repository controls.
  • Enables suppression for in-session chats.
  • Updates centering styles and adds regression coverage.
File Description
newChatInput.test.ts Tests repository-control suppression.
newChatInSessionWidget.ts Disables repository controls in-session.
newChatInput.ts Adds conditional control rendering.
newChatInSession.css Centers the in-session composer.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/sessions/contrib/chat/browser/media/newChatInSession.css
Comment thread src/vs/sessions/contrib/chat/test/browser/newChatInput.test.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants