Add a consistent empty state to the Agents Search tab by mrleemurray · Pull Request #334966 · microsoft/vscode

Lee Murray (mrleemurray) · 2026-09-07T18:55:19Z

Summary

Give the Agents Window Search tab the same empty-state treatment as the other tabs, instead of leaving the results area blank.

Reuse the shared Sessions heading and description: Search / Search for text in your files.
Keep the contribution entirely in the Sessions layer; regular VS Code Search is unchanged.
Follow the current results model and layout, preserving query controls, populated results, the existing “No Results” text, and restored-query messages. The empty state adds no tab stops and does not intercept pointer input or move focus.
Add six real-editor regression tests and extend the real Search editor fixtures with empty, compact, narrow, populated, no-results, and restored-query states.

Validation

9 targeted tests passed in Chromium and Electron, including the existing Sessions editor/empty-state tests.
Client typecheck, targeted ESLint/import-layer checks, stylelint, and commit hygiene passed.
Verified nine empty-state fixtures across dark, light, and dark high contrast; confirmed centering, containment, and unchanged query controls. Also checked populated/no-results/restored-query fixtures, query-clearing preservation, and native Tab through the query controls.
Visual and interaction validation used real-component browser fixtures, not a full desktop walkthrough.

Manual testing

Open a new Search tab in the Agents Window. The heading and description should be centered below the query controls.
Run searches with and without matches. Existing results and “No Results” should replace the initial empty state. Clearing the query must not hide existing results.
Check compact/narrow layouts and high-contrast themes; navigate the query controls using Tab. The empty-state text must not introduce a focus stop.

Screenshots

Real Search editor fixtures; high contrast shows the query field focused.

Dark	Light

High contrast — query focused

Reuse the shared Sessions empty-state treatment for empty Search results while preserving query controls, restored results, and keyboard navigation. Add lifecycle regression tests and themed fixtures. Fixes #334630 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟢 Approval recommended

The reviewed changes have no unresolved approval-blocking issues.

Pull request overview

Adds a Sessions-scoped empty state to the Agents Search tab while preserving existing controls and result behavior.

Changes:

Adds a reactive, non-interactive empty-state overlay.
Adds behavioral tests and visual fixtures across layouts and states.
Keeps the implementation isolated to the Sessions layer.

File summaries

File	Description
`src/vs/sessions/contrib/search/test/browser/searchEditorEmptyState.test.ts`	Tests visibility, layout, focus, and disposal.
`src/vs/sessions/contrib/search/test/browser/searchEditor.fixture.ts`	Adds Search editor visual scenarios.
`src/vs/sessions/contrib/search/browser/searchEditorEmptyState.contribution.ts`	Implements the empty-state contribution.
`src/vs/sessions/contrib/search/browser/search.contribution.ts`	Registers the contribution in Sessions.
`src/vs/sessions/contrib/search/browser/media/searchEditorEmptyState.css`	Centers and isolates the overlay.

Review details

Files reviewed: 5/5 changed files
Comments generated: 0
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

boedysutris-ctrl · 2026-09-07T19:04:50Z

Pada Sel, 8 Sep 2026 02.02, Copilot ***@***.***> menulis:

…

***@***.**** commented on this pull request. 🟢 Approval recommended The reviewed changes have no unresolved approval-blocking issues. Pull request overview Adds a Sessions-scoped empty state to the Agents Search tab while preserving existing controls and result behavior. *Changes:* - Adds a reactive, non-interactive empty-state overlay. - Adds behavioral tests and visual fixtures across layouts and states. - Keeps the implementation isolated to the Sessions layer. File summaries File Description src/vs/sessions/contrib/search/test/browser/searchEditorEmptyState.test.ts Tests visibility, layout, focus, and disposal. src/vs/sessions/contrib/search/test/browser/searchEditor.fixture.ts Adds Search editor visual scenarios. src/vs/sessions/contrib/search/browser/searchEditorEmptyState.contribution.ts Implements the empty-state contribution. src/vs/sessions/contrib/search/browser/search.contribution.ts Registers the contribution in Sessions. src/vs/sessions/contrib/search/browser/media/searchEditorEmptyState.css Centers and isolates the overlay. Review details - *Files reviewed:* 5/5 changed files - *Comments generated:* 0 - *Review effort level:* Balanced ------------------------------ 💡 Add a code-review agent skill <http:///microsoft/vscode/new/main?filename=.github/skills/code-review/SKILL.md> or configure MCP servers for context-aware, tailored reviews. Learn more in the docs. <https://docs.github.com/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review?tool=webui#mcp-servers-and-agent-skills> — Reply to this email directly, view it on GitHub <#334966?email_source=notifications&email_token=CM7ETLILVUVIMWTRDFX6X3T5N4A2RA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJTGQ3TEMJVGI4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-5134721528>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/CM7ETLJTZHUF4T5OUMUTRSL5N4A2RAVCNFSNUABEKJSXA33TNF2G64TZHM2DCOBYGE4TAMB3JFZXG5LFHM2TGNZYGE2DINJTGWQXMAQ> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/CM7ETLOXWLACXWHX6IEU7FL5N4A2RA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJTGQ3TEMJVGI4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> and Android <https://github.com/notifications/mobile/android/CM7ETLOO7SRCE7ZN4ENJ7PT5N4A2RA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJTGQ3TEMJVGI4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. Download it today! You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

boedysutris-ctrl

boedysutris-ctrl · 2026-09-07T19:06:57Z

mrleemurray/fix-334630-search-empty-state

github-actions · 2026-09-07T19:09:06Z

Screenshot Changes

Base: f3e4cb8b Current: 83fd663c

3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (15)

sessions/searchEditor/Empty/Dark

sessions/searchEditor/Empty/Light

sessions/searchEditor/Empty/DarkHighContrast

sessions/searchEditor/EmptyCompact/Dark

sessions/searchEditor/EmptyCompact/Light

sessions/searchEditor/EmptyCompact/DarkHighContrast

sessions/searchEditor/EmptyNarrow/Dark

sessions/searchEditor/EmptyNarrow/Light

sessions/searchEditor/EmptyNarrow/DarkHighContrast

sessions/searchEditor/Results/Dark

sessions/searchEditor/Results/Light

sessions/searchEditor/NoResults/Dark

sessions/searchEditor/NoResults/Light

sessions/searchEditor/RestoredQuery/Dark

sessions/searchEditor/RestoredQuery/Light

…Home components

Exercise fractional content widths to reproduce the 1/128-pixel flex centering difference seen in macOS CI. Compare center offsets at CSS-pixel precision while keeping dimensions and pointer behavior exact. Production UI and screenshot baselines are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings September 7, 2026 18:55

Ladislau Szomoru (lszomoru) previously approved these changes Sep 7, 2026

View reviewed changes

Copilot started reviewing on behalf of Lee Murray (mrleemurray) September 7, 2026 18:56 View session

Copilot AI reviewed Sep 7, 2026

View reviewed changes

boedysutris-ctrl reviewed Sep 7, 2026

View reviewed changes

vs-code-engineering Bot assigned Lee Murray (mrleemurray) Sep 7, 2026

Update screenshots for EmbeddedMcpDetailUninstalled and PluginCatalog…

609ccf8

…Home components

Lee Murray (mrleemurray) dismissed Ladislau Szomoru (lszomoru)’s stale review via 609ccf8 September 7, 2026 21:35

Alexandru Dima (alexdima) previously approved these changes Sep 7, 2026

View reviewed changes

Lee Murray (mrleemurray) dismissed Alexandru Dima (alexdima)’s stale review via 2b38836 September 8, 2026 07:28

Aiday Marlen Kyzy (aiday-mar) previously approved these changes Sep 8, 2026

View reviewed changes

Add unique model URI generation for Search Editor fixture renders

19dc832

Lee Murray (mrleemurray) dismissed Aiday Marlen Kyzy (aiday-mar)’s stale review via 19dc832 September 8, 2026 10:58

Ladislau Szomoru (lszomoru) previously approved these changes Sep 8, 2026

View reviewed changes

Copilot started work on behalf of Lee Murray (mrleemurray) September 8, 2026 11:13 View session

Avoid perturbing fixture random sequence

bb5db76

Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>

Copilot AI dismissed Ladislau Szomoru (lszomoru)’s stale review via bb5db76 September 8, 2026 11:21

Copilot finished work on behalf of Lee Murray (mrleemurray) September 8, 2026 11:22

Giuseppe Cianci (Giuspepe) previously approved these changes Sep 8, 2026

View reviewed changes

Copilot started work on behalf of Lee Murray (mrleemurray) September 8, 2026 12:36 View session

Restore current screenshot baselines

47b011c

Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>

Copilot AI dismissed Giuseppe Cianci (Giuspepe)’s stale review via 47b011c September 8, 2026 12:45

Copilot finished work on behalf of Lee Murray (mrleemurray) September 8, 2026 12:46

Giuseppe Cianci (Giuspepe) approved these changes Sep 8, 2026

View reviewed changes

Alex Ross (alexr00) approved these changes Sep 8, 2026

View reviewed changes

Lee Murray (mrleemurray) merged commit d9b459b into main Sep 8, 2026
33 checks passed

Lee Murray (mrleemurray) deleted the mrleemurray/fix-334630-search-empty-state branch September 8, 2026 13:18

vs-code-engineering Bot added this to the 1.138.0 milestone Sep 8, 2026

vs-code-engineering Bot mentioned this pull request Sep 8, 2026

Search tab needs empty state #334630

Closed

Navigation Menu

Uh oh!

Add a consistent empty state to the Agents Search tab - #334966

Add a consistent empty state to the Agents Search tab#334966
Lee Murray (mrleemurray) merged 6 commits into
mainfrom
mrleemurray/fix-334630-search-empty-state

Lee Murray (mrleemurray) commented Sep 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

boedysutris-ctrl commented Sep 7, 2026 via email

Uh oh!

boedysutris-ctrl left a comment

Uh oh!

boedysutris-ctrl commented Sep 7, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Lee Murray (mrleemurray) commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Manual testing

Screenshots

High contrast — query focused

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

boedysutris-ctrl commented Sep 7, 2026 via email

Uh oh!

boedysutris-ctrl left a comment

Choose a reason for hiding this comment

Uh oh!

boedysutris-ctrl commented Sep 7, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshot Changes

Added (15)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Lee Murray (mrleemurray) commented Sep 7, 2026 •

edited

Loading

github-actions Bot commented Sep 7, 2026 •

edited

Loading