[cherry-pick] Add unread treatment for Automations new badge - #334971
Merged
Ulugbek Abdullaev (ulugbekna) merged 1 commit intoSep 7, 2026
Merged
Conversation
* automations: feat: add unread new badge treatment Reuse the standard Automations unread status indicator as an alternative first-use treatment while preserving operational status precedence and accessibility semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * automations: test: gate unread badge screenshots Opt the unread Automations badge fixture into the blocking screenshot gate so theme and rendering regressions are detected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * automations: test: accept unread badge screenshots Record the Linux CI hashes for the unread Automations badge in dark, high-contrast, and light themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 1b921e3)
Copilot started reviewing on behalf of
Ulugbek Abdullaev (ulugbekna)
September 7, 2026 20:15
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is narrowly scoped, updates UI + configuration + fixtures/tests consistently, and preserves existing accessibility labeling behavior via the existing automationNewBadgeVisible aria-label augmentation.
Review tier: Lite
Findings: None
What changed in this PR
Cherry-picks the “unread” visual treatment for the Automations New badge onto release/1.137, adding a fourth badge style that reuses the standard filled unread indicator in the Automations leading icon slot while suppressing the trailing New capsule. This integrates into the existing Sessions list rendering, configuration schema, component fixtures, and unit tests without altering the underlying Automations eligibility logic (already backported separately).
Changes:
- Add
unreadas a supportedAutomationsNewBadgeStyleand configuration enum value. - Update Sessions list rendering so the Automations row hides the trailing New capsule for
unreadand shows the filled unread indicator in the leading icon slot. - Extend component screenshot fixtures and unit tests to cover the new
unreadtreatment and its precedence behavior.
| File | Description |
|---|---|
| test/componentFixtures/blocks-ci-screenshots.md | Adds new baseline screenshot entries for the unread Automations badge treatment across themes. |
| src/vs/workbench/test/browser/componentFixtures/sessions/sessionsList.fixture.ts | Updates fixture status-icon behavior and adds a new screenshot fixture for automationBadgeStyle: 'unread'. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Expands coverage to assert DOM/icon behavior for outline vs unread badge presentations and precedence with running status. |
| src/vs/sessions/contrib/sessions/test/browser/automationsNewBadge.test.ts | Extends AutomationsNewBadgeState tests to include the new unread style in supported-style resolution and updates related expectations. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts | Implements the unread presentation: hides trailing badge capsule and renders unread indicator in the leading icon slot while preserving status precedence. |
| src/vs/sessions/contrib/sessions/browser/sessions.contribution.ts | Adds 'unread' to the sessions.automations.newBadgeStyle enum list. |
| src/vs/sessions/contrib/sessions/browser/automationsNewBadge.ts | Extends AutomationsNewBadgeStyle union and treatment parsing to accept 'unread'. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 5 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Added (3)
|
Ulugbek Abdullaev (ulugbekna)
enabled auto-merge
September 7, 2026 20:57
Ulugbek Abdullaev (ulugbekna)
disabled auto-merge
September 7, 2026 20:57
Ulugbek Abdullaev (ulugbekna)
enabled auto-merge (squash)
September 7, 2026 20:57
Alexandru Dima (alexdima)
approved these changes
Sep 7, 2026
Ulugbek Abdullaev (ulugbekna)
deleted the
ulugbekna/cherry-pick-334946-release-1.137
branch
September 7, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #334946 from
mainontorelease/1.137.The release branch already includes the prerequisite Automations New badge eligibility backport from #334944.
Verification
npm run transpile-clientA full compile reaches source generation but is currently blocked by the pre-existing
release/1.137monaco.d.tsmismatch; this cherry-pick does not modify Monaco sources or declarations.