sessions: back the checkpoint and fork rows over a chat background - #334985
Merged
Conversation
The Restore Checkpoint, Start Over and fork controls are transparent at rest and only pick up a fill on hover, so over a chat background they read straight on the wallpaper. Back each row's toolbar and its sibling text with one opaque plate, the way the editor-instance restore row already does in chat.css, rather than plating each control. The controls stay transparent, so their existing hover fill composites over the plate and the confirming Restore Checkpoint pill keeps rendering as a single unit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Ulugbek Abdullaev (ulugbekna)
approved these changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused styling change matches the stated behavior and includes appropriate regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Adds opaque backing surfaces to checkpoint and fork controls when Sessions uses a chat background.
Changes:
- Applies the session background beneath checkpoint controls and restore-row text.
- Adds regression coverage for background and plain-session rendering.
| File | Description |
|---|---|
chatView.css |
Adds chat-background-specific control backing. |
chatView.test.ts |
Verifies conditional opaque fills. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Restore Checkpoint, Start Over and fork controls in the conversation are transparent at rest — only
:hovergives them a fill (chat.css:4379,chat.css:4410). Neither row sits inside the opaque.request-hover; all three are siblings onrowContainer(chatListRenderer.ts:1084/1100/1172). So over a chat background they read straight on the wallpaper.This is the same gap #334655 closed for the new-session composer, one level up in the transcript.
What changed
One rule in the sessions layer, scoped to
.has-chat-background. It backs the toolbar and its sibling text with one opaque plate rather than plating each control — the movechat.css:4574-4580already makes for the editor-instance restore row.Plating the container instead of the controls buys three things:
chat.css:4410..confirmingRestore Checkpoint pill still owns its own surface and keeps itsbackground-clip: textgradient (chat.css:4422-4437). No exception needed..checkpoint-dot-separatoris the one selector beyond the editor-instance precedent: it sits between the label and the toolbar on the restore row, so leaving it out would strand it on the wallpaper between two plates.Appearance without a chat background is untouched — nothing in workbench
chat.csschanges.Verification
./scripts/test.sh --grep "Sessions - Chat View"— 31 passing. The new case builds both rows under a backed and a plain.part.sessionspartand snapshots the four fills againstrgba(0, 0, 0, 0)..checkpoint-container .monaco-toolbarcomputesrgb(25, 26, 27)(--session-view-background); "Restore Checkpoint · ⑂" reads as one continuous band, and the hover fill still lands on top..checkpoint-restore-containerhasgap: 4px, so its three plates leave two 4px seams. They're invisible in practice — the row reads as one band. If a busier image ever exposes them, the fix is abox-shadowbleed on the plated elements, which closes the gaps without touching layout. Not adding it preemptively.🤖 Generated with Claude Code