Skip to content

[cherry-pick] agentHost: Make Agent Merge enablement experiment configurable - #335007

Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
mainfrom
cherry-pick/334973
Sep 8, 2026
Merged

[cherry-pick] agentHost: Make Agent Merge enablement experiment configurable#335007
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
mainfrom
cherry-pick/334973

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #334973 from release/1.137.

Summary

  • allow experiments to override the default value of chat.agentMerge.enabled
  • use automatic experiment updates so the resolved value continues to sync through the existing Agent Host configuration bridge

Testing

  • npm run eslint -- src/vs/platform/agentHost/common/agentHostStarter.config.contribution.ts
  • npm run typecheck-client

Copilot AI balanced review requested due to automatic review settings September 8, 2026 07:24
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, consistent with existing experiment: { mode: 'auto' } usage in the same configuration contribution, and aligns with the stated goal of enabling automatic experiment updates.

Pull request overview

Makes the chat.agentMerge.enabled setting eligible for automatic experiment-driven overrides so the effective value can be updated dynamically and propagated through the existing Agent Host configuration bridge.

Changes:

  • Adds experiment: { mode: 'auto' } to chat.agentMerge.enabled configuration schema entry.
  • Enables experimentation service to override the default without requiring manual refresh/restart paths.
File summaries
File Description
src/vs/platform/agentHost/common/agentHostStarter.config.contribution.ts Marks chat.agentMerge.enabled as auto-experimentable so experiments can override the default and keep syncing to the agent host.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@benibenj
Benjamin Christopher Simmonds (benibenj) merged commit 2e04a11 into main Sep 8, 2026
34 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants