Skip to content

Make ProductCode matching case-insensitive for REST sources - #6636

Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
microsoft:masterfrom
huong8373tt-beep:fix/2558-productcode-casefold
Open

Slai.life (huong8373tt-beep) wants to merge 1 commit into
microsoft:masterfrom
huong8373tt-beep:fix/2558-productcode-casefold

Conversation

@huong8373tt-beep

@huong8373tt-beep Slai.life (huong8373tt-beep) commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Fixes #2558.

REST sources can preserve the casing used by manifest ProductCode values, while installed ARP data and client queries may use different casing. Single-package searches now request ProductCode matching as CaseInsensitive, so REST sources can match the same ProductCode without requiring server-side lowercasing.

The existing PackageFamilyName behavior remains unchanged.

🔍 Validation

  • Added a focused workflow regression test covering the generated ProductCode search filter.
  • Passed: git diff --cached --check.
  • Passed: release-note fragment merge for 1.31.
  • A focused native C++ build was attempted, but local dependency acquisition was blocked by the available build environment. GitHub CI is the build and test authority for this change.

✅ Checklist

🤖 AI Assistance

  • AI assistance was used and has been disclosed in this PR
  • No AI assistance was used

Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Oct 30, 2026
@huong8373tt-beep

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 6636 in repo microsoft/winget-cli

@huong8373tt-beep
Slai.life (huong8373tt-beep) marked this pull request as ready for review October 30, 2026 10:49
@huong8373tt-beep
Slai.life (huong8373tt-beep) requested a review from a team as a code owner October 30, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Bug It either shouldn't be doing this or needs an investigation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Case-folding of "ProductCode" field

1 participant