Skip to content

Skip approved archive scans before loading large ZIPs - #6638

Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
microsoft:masterfrom
huong8373tt-beep:fix/6632-skip-local-archive-scan
Open

Slai.life (huong8373tt-beep) wants to merge 1 commit into
microsoft:masterfrom
huong8373tt-beep:fix/6632-skip-local-archive-scan

Conversation

@huong8373tt-beep

@huong8373tt-beep Slai.life (huong8373tt-beep) commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Resolves #6632.

When a local manifest explicitly requests --ignore-local-archive-malware-scan and the administrator setting permits that override, WinGet now skips the archive malware scan before loading the ZIP. This avoids the scan's full-archive memory allocation for approved large archive installs, including the x86 validation scenario described in the issue.

The default scan path is unchanged when the override is absent or not permitted. The installer workflow still performs the normal archive extraction and nested-installer validation steps.

🔗 References

Resolves #6632

🔍 Validation

  • Added regression coverage to verify the approved override does not call Archive::ScanZipFile() and reports the skip to the user.
  • Preserved coverage for scan failure when the override is not permitted.
  • Parsed the updated resource XML successfully.
  • git diff --check passed.
  • Merge-ReleaseNotes.ps1 -Version 1.31 passed.
  • A focused native C++ build was attempted, but local vcpkg dependency acquisition was blocked while downloading the Brotli source archive; the test binary was not produced or run. GitHub CI remains the full build-and-test authority for this change.

✅ Checklist

🤖 AI Assistance

  • AI assistance was used and has been disclosed in this PR
  • No AI assistance was used

Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@huong8373tt-beep
Slai.life (huong8373tt-beep) marked this pull request as ready for review October 30, 2026 10:50
@huong8373tt-beep
Slai.life (huong8373tt-beep) requested a review from a team as a code owner October 30, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x86 validation: bad allocation before extracting ~614 MiB portable ZIPs (1.29.280)

1 participant