Skip to content

Fix fuzzing build #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcPMS merged 1 commit into from
Oct 30, 2026
+6 −0
Merged

Fix fuzzing build #6639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/AppInstallerSharedLib/Hash.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ namespace
return targetFileHash;
}

#ifndef WINGET_DISABLE_FOR_FUZZING
Hash::HashBuffer Hash::ComputeHashFromHandle(HashAlgorithm algorithm, HANDLE fileHandle)
{
constexpr DWORD bufferSize = 1024 * 1024;
Expand All @@ -238,6 +239,7 @@ namespace

return hasher.Get();
}
#endif

bool Hash::AreEqual(const HashBuffer& first, const HashBuffer& second)
{
Expand Down
4 changes: 4 additions & 0 deletions src/AppInstallerSharedLib/Public/winget/Hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,11 @@ namespace AppInstaller::Cryptography {
// Computes the hash from a given file path.
static HashBuffer ComputeHashFromFile(HashAlgorithm algorithm, const std::filesystem::path& path);

#ifndef WINGET_DISABLE_FOR_FUZZING
// Computes the hash from an open file HANDLE by reading sequentially from the current position.
// The caller retains ownership of the handle.
static HashBuffer ComputeHashFromHandle(HashAlgorithm algorithm, HANDLE fileHandle);
#endif

static std::string ConvertToString(const HashBuffer& hashBuffer, size_t hashBufferSizeInBytes);

Expand Down Expand Up @@ -156,10 +158,12 @@ namespace AppInstaller::Cryptography {
return Hash::ComputeHashFromFile(Algorithm, path);
}

#ifndef WINGET_DISABLE_FOR_FUZZING
static HashBuffer ComputeHashFromHandle(HANDLE fileHandle)
{
return Hash::ComputeHashFromHandle(Algorithm, fileHandle);
}
#endif

static std::string ConvertToString(const HashBuffer& hashBuffer)
{
Expand Down
Loading