Repository navigation
fix(typecheck): annotate value-range subclass patching - #1464
Closed
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 1 commit into
Closed
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 1 commit into
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 1 commit into
Conversation
Qiong Wu (qiowu) (DingmaomaoBJTU)
requested a review
from a team
as a code owner
October 9, 2026 03:11
Qiong Wu (qiowu) (DingmaomaoBJTU)
enabled auto-merge (squash)
October 9, 2026 04:05
Qiong Wu (qiowu) (DingmaomaoBJTU)
disabled auto-merge
October 9, 2026 07:34
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit types for the recursive subclass traversal and collected subclass list in
value_range.py, allowing mypy to verify dynamicgeneratepatching withoutattr-definedignores. Runtime behavior is unchanged.