Skip to content

Pin GitHub Actions to full-length commit SHAs - #2006

Merged
Gavin Barron (gavinbarron) merged 2 commits into
microsoftgraph:devfrom
danfiedler-msft:danfiedler/pin-actions
Oct 23, 2026
Merged

Gavin Barron (gavinbarron) merged 2 commits into
microsoftgraph:devfrom
danfiedler-msft:danfiedler/pin-actions

Conversation

@danfiedler-msft

Copy link
Copy Markdown
Contributor

Summary

This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.

Why?

Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.

This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.

What changed?

Action pinning: Third-party action references in .github/workflows/ that used mutable tag-based references (e.g., actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g., actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.

Dependabot configuration: .github/dependabot.yml has been updated to ensure a github-actions package-ecosystem section is present with a cooldown configuration (default-days: 7). If the file did not exist, it was created. If a github-actions section already existed, only the cooldown block was added or its default-days value was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.

Is this safe to merge?

Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for actions/checkout@v7 can be found in the sha property in the JSON response for GET https://api.github.com/repos/actions/checkout/commits/v7).

Additional Information

For more information, please see https://aka.ms/action-pinning

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Resolve workflow conflicts using the action versions shared by main and dev, preserving the Node.js 22/24/26 matrix. Pin checkout v6.1.0, setup-node v6.5.0, CodeQL v4.39.1, and create-github-app-token v3.3.0 to their upstream commit SHAs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7934710e-193d-4f81-97ee-b099a816c2e9
@gavinbarron
Gavin Barron (gavinbarron) merged commit 0f906b5 into microsoftgraph:dev Oct 23, 2026
8 checks passed
Gavin Barron (gavinbarron) added a commit that referenced this pull request Nov 5, 2026
* ci: Pin GitHub Actions to full-length commit SHAs (#2006)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7934710e-193d-4f81-97ee-b099a816c2e9

* ci: migrate production build to official 1ES template

Separate SDK build and tests from opt-in release artifact publication. Preserve the Node.js matrix and Linux build, and document pipeline authorization and downstream artifact compatibility.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: publish release artifacts only on version tag pushes

Bump package and generated SDK version to 3.1.0. Replace manual publication with tag-push CI gating, validate tags against the package version, and update release instructions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: model npm releases on the TypeScript SDK ESRP pipeline

Pack the built single-package SDK without lifecycle scripts and deploy the immutable tarball through the shared production ESRP environment. Retain tag-push-only release gating and document resource authorization, package scope, and legacy publisher cutover.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: require matching vX.X.X release tags

Filter tag triggers and publication to v-prefixed tags and reject malformed or version-mismatched release tags before packaging. Document v3.1.0 as the release tag.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: enforce exact release tag format before version matching

Validate the entire tag, including trailing line terminators, and report missing source refs, malformed versions, and package-version mismatches separately.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Revert strict whole-tag validation hardening

Reverts commit 8488858 at user request; restores the preceding release tag and package version check.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: filter release tags at the pipeline trigger only

Use v*.*.* at line 9 and remove build-time tag validation as requested. Document wildcard limitations and manual package-version verification.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* ci: restore release tag package-version equality check

Preserve the original inline check with v-prefix matching and retain the v*.*.* tag trigger at line 9.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Dan Fiedler <151573964+danfiedler-msft@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7934710e-193d-4f81-97ee-b099a816c2e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants