fix(xiaoyunque): support reference video assets#25
Merged
Conversation
superche
marked this pull request as ready for review
July 22, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upload_filereference-video results throughAssetCreateV2whenpippit_asset_idis missing or blankxiaoyunque-generation0.3.5 with companion 0.3.3 and Registry sequence 24Follow-up to #19.
Root cause
upload_fileuses asset type1for video and may return only an EverPhotoasset_id. The generation payload also needs the registered Pippit identity. #19 registered upload type2(images), so reference video could reach submission withoutpippit_asset_id.Impact
Reference videos uploaded from Convax are now registered before generation submission. Existing uploads that already return
pippit_asset_idremain unchanged. Registration failures stop before submission and expose only stable safe diagnostics.Validation
bun install --frozen-lockfile --ignore-scriptsbun run check(workspace builds/typechecks/tests, companion builds/smokes, tooling tests, validation, packing, and Registry/Showcase index generation)No live or billable XiaoYunque generation was triggered.