test(uncheck): rewrite the tests as e2e suites with 100% coverage

[dinwwwh]

Replaces the in-process unit tests with end-to-end tests that spawn the real CLI in real projects, one folder per command (uncheck, staged, prepare, hooks install, hooks run). Every behavior runs in both a single repo and a pnpm monorepo. Together the suites cover 100% of statements, branches, functions and lines of packages/uncheck/src, and CI now enforces that threshold.

Tests

• 664 tests in 47 files. Each one builds a real project in a temp folder (package.json, lockfile, tsconfig, sources, git history, the real tools linked into node_modules) and runs the CLI from source as a subprocess. Subprocess coverage is collected with vitest's autoAttachSubprocess.
• Edge cases are reached from outside the process:
  • signals during a check, and stdout closed early
  • unreadable folders
  • fake tools that crash or edit files
  • a git wrapper simulating git older than 2.26
  • a simulated Yarn PnP install
  • the interactive agent prompt in a pseudo-terminal
  • real git commit runs through the hook prepare writes
• Machine settings can no longer leak in. Locale and TERM are pinned and NODE_OPTIONS is dropped. Git cannot find a repository above the test folders, and the harness refuses to start if a package.json, node_modules or lockfile sits above the temp dir.
• pnpm run test:coverage takes about 4 minutes on 8 CPUs.

Source changes

• Unreachable fallbacks are removed: defaults for git output git always prints, a ?? '' after a filter that always matches, a redundant Array.isArray check, and an instanceof Error check on errors that always carry one.
• Windows/macOS-only branches are removed, since the code paths no longer differ by platform.
• An empty file list now produces no batch at all, so a path-less git reset can never run.
• No user-facing behavior changes.

Notes for reviewers

• Tests that rely on chmod are skipped as root, where permissions have no effect, so a coverage run as root can fall below 100%.
• The tests found three path-resolution bugs. Two are pinned by the current tests as if intended. These are left for a follow-up:
  • paths above the working directory are rejected by oxlint and oxfmt
  • !pattern exclusions always go through the glob matcher
  • a symlinked folder inside git gets checked twice

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/uncheck@19

commit: 3de71d5

[pullfrog]

ℹ️ No critical issues — the e2e rewrite is thorough and its assertions are exact; two of the source cleanups are not strictly behavior-preserving.

Reviewed changes

• E2e test rewrite — replaces the in-process unit tests with spawned-CLI suites, one folder per command (uncheck, staged, prepare, hooks install, hooks run), each run in both a single repo and a pnpm monorepo.
• Shared harness — tests/utils/project.ts builds real temp projects with real git and real tools; tests/utils/register.ts loads src/bin.ts via Node's registerHooks; the environment is pinned and refuses to start if a project marker leaks in from above TMPDIR.
• Subprocess coverage — vitest.config.ts adds autoAttachSubprocess and a global thresholds: { 100: true }; collection rides on NODE_V8_COVERAGE, which environment() preserves.
• Source cleanups — tsc.ts case handling, errors.ts platformMessage, tool.ts argvBatches/MAX_ARGV_LENGTH, staged.ts gitEach, hooks/run.ts summary extraction and prepare.ts destructuring all drop fallbacks described as unreachable.
• Old unit tests removed — command.test.ts, files.test.ts, fixture.ts, tool.test.ts, tsc.test.ts.

ℹ️ New tests pin three known path-resolution bugs as intended behavior

The PR notes that three path-resolution bugs are now pinned by the suite "as if intended": paths above the working directory rejected by oxlint/oxfmt, !pattern exclusions always going through the glob matcher, and a symlinked folder inside git being checked twice. Encoding today's output as the expected value is reasonable for a regression baseline, but it does mean the follow-up fix will have to churn these tests rather than confirm a behavior they never asserted. Worth a tracking issue now so the follow-up is not deferred indefinitely.

Technical details

# Pinned bugs

## Affected sites
- `packages/uncheck/tests/uncheck/paths-exclusions.test.ts` — `!` exclusions and glob-like names pinned as-is.
- `packages/uncheck/tests/uncheck/paths-*.test.ts` — above-cwd and symlink cases.
- `packages/uncheck/src/files.ts` — `resolvePaths` / `existingFiles`, the likely fix site.

## Open questions for the human
- Are these three follow-ups already tracked, or should a tracking issue be opened so the now-pinned expectations get revisited?

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (default — pick a model for stronger reviews) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes — the delta since Pullfrog review 5374082387 (3d94946..401457d):

• Fixed tsc include case handling — compileGlob now returns a matcher that unions a case-sensitive and a case-folded include regex, so it is a true superset of tsc on either filesystem kind while exclude keeps case.
• Pinned the fix with a regression test — tsc-patterns covers case-variant node_modules/.min.js; I confirmed it fails against the pre-fix always-i include regex.
• Made two assertions machine-independent — the prepare EISDIR expectation tolerates Node 26's appended path, and the staged index.lock expectation checks the first error line so git's trailing advice no longer matters.
• Stabilized oxlint under Actions — the harness environment now strips GITHUB_ACTIONS, so oxlint prints its normal report instead of GitHub annotations.

Both relaxed assertions still pin their specific failure (they are toContain/replace of the exact message, not truthiness), and all three affected tests pass in this Actions environment on Node 24.

  ^{｜ Fix it ➔ ｜ View workflow run ｜ Using DeepSeek Flash (default — pick a model for stronger reviews) ｜ 𝕏}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[pullfrog]

ℹ️ No critical issues — one minor test-assertion suggestion inline.

Reviewed changes — the delta since Pullfrog review 5374168756 (401457d..f480c19):

• Fixed the spawned processes' environment — environment() now builds every child's environment from a strict allowlist (HOME, TMPDIR, NODE_V8_COVERAGE) instead of filtering the machine's variables, so tools can no longer see CLAUDECODE/CI and switch to a different output format.
• Reworked two oxlint assertions — paths-git and paths now match oxlint's default reporter marker (,-[<file>:<line>:<col>]) in place of the agent format the old assertions were written against.

The allowlist is the right shape and the suite (including the pseudo-terminal tests) passes on Node 24; the suggestion is on the new assertions themselves.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (default — pick a model for stronger reviews) ｜ 𝕏}