Expose test-result file URLs, configurable cookie Secure flag, fix config drift - #237
Merged
HermanPlay merged 2 commits intoAug 10, 2026
Merged
Conversation
…fix config drift - TestResult schema gains stdoutUrl/stderrUrl/diffUrl signed URLs (submission detail preloads file relations) - refresh-token cookie Secure flag now env-driven (COOKIE_SECURE), default false - fix FILE_STORAGE_PORT doc drift (.env.example used public 8888) - correct APP_PORT doc comment; document FILE_STORAGE_PUBLIC_URL/COOKIE_SECURE
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Copilot stopped reviewing on behalf of
HermanPlay due to an error
August 10, 2026 19:27
…t v2.12.2, pin CI version - config.go: define all env var names as constants (envDBHost, envAPPPort, ...), use them in NewConfig and config_test.go - filestorage service/validation_rules: extract context-key and directory constants - test files: replace repeated string literals with constants (goconst) - pin golangci-lint to v2.12.2 in pre-commit + copilot-setup workflows (was @latest; version drift flagged pre-existing goconst issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #234, #235, #236.
Changes
Test-result file URLs (#234)
TestResultschema gainsstdoutUrl,stderrUrl,diffUrl(signed, omitempty).testResultsModelToSchemapopulates them viaGetSignedFileURL(helpersignedFileURL, empty string on failure).submissionRepository.Get(detail) preloadsResult.TestResults.{StdoutFile,StderrFile,DiffFile}so the relations are available.make docs.Cookie Secure flag (#235)
setRefreshTokenCookie+ logout cookie clear now use an env-driven flag.COOKIE_SECUREconfig (APIConfig.CookieSecure, default false), wired throughinitialization→NewAuthRoute.COOKIE_SECURE=true.Config drift (#236)
.env.exampleFILE_STORAGE_PORT8888 → 8081 (internal server; 8888 is public/unsigned).API_PORT→APP_PORTdoc comment; documentedFILE_STORAGE_PUBLIC_URLandCOOKIE_SECURE.Verification
go build,go vet,go test ./...pass.TestGetSignedTestResultURLs,TestRefreshTokenCookieSecureFlag.