Repository navigation
Conversation
Collaborator
|
Closing in favor of the same-repo PR #2146 (identical branch content; keeps the CI review workflow active). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
At startup the node logged its entire parsed command line at INFO level, including
rpc_username,rpc_passwordand--chain-genesis-staking-settings(which carries staking and VRF private keys). The log file was created with default umask permissions (typically 0644) and its level was not configurable, so the secrets landed world-readable on disk on every start. Separately, clap's[env: NAME=value]help rendering displayed environment-sourced values for these options, and the API server daemons logged the postgres connection string including the password at debug level.Change
Redacted<T>wrapper (zeroizingDebug) for RPC credential fields; redactedDebugforGenesisStakingSettings(pool id stays visible, private keys do not).hide_env_values) across node-lib, wallet-cli, wallet-rpc and the API server daemons; guard tests pin every option as classified secret/non-secret, and the classification helper recurses into subcommands.Testing
cargo testgreen for affected crates; workspace fmt/clippy checks pass.