Repository navigation
fix: retry cold ipfs proxy connects once per gateway - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Token icons kept disappearing intermittently even though the deployed /ipfs proxy code was correct. In-container instrumentation showed the route's upstream fetch to the production proxy failing with connect-level ETIMEDOUT well under the 12s gateway budget — and succeeding on an immediate identical retry. Cold connects from a small container to the proxy flake; the route treated a network throw the same as a gateway failure and moved on (with a single default gateway, straight to 502), so token metadata resolved to null and the UI showed letter avatars.
Fix
[...path].test.tsas a phantom endpoint route importing vitest, which does not exist in production (any future/ipfs/*.testrequest would 500).Tests