feat(release): ship the stdio bridge inside the packaged app - #38
Merged
Merged
Conversation
The bridge was only usable from a source checkout: release zips did not contain it, although the skill and the bridge header said it could run from an install. electron-builder now copies the bridge and the four compiled modules it loads (mcp-instructions, mcp-prompts, mcp-tool-router, mcp-tools) into resources/mcp-bridge/, keeping the bridge/ + lib/common/ layout so its existing ../lib/common require resolves unchanged. No bridge code changes. A new bridge test guards against drift: it derives every module the bridge loads (and their relative requires) and fails if extraResources does not copy one. README, bridge README and skill now give the installed path per OS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The stdio bridge from #36 was only usable from a source checkout. Release zips didn't contain it, even though the skill and the bridge's header comment said it could run from an install. This PR ships it inside the packaged app.
electron-app/package.jsongets twoextraResourcesentries. They copybridge/arduino-agent-bridge.jsand the four compiled modules it loads (mcp-instructions,mcp-prompts,mcp-tool-router,mcp-tools) intoresources/mcp-bridge/. Thebridge/+lib/common/layout is preserved, so the bridge's existing../lib/commonrequire resolves without code changes.release.ymlalready compilesarduino-mcp-extension/libbefore packaging.<unzipped folder>/resources/mcp-bridge/bridge/arduino-agent-bridge.jsArduino IDE.app/Contents/Resources/mcp-bridge/bridge/arduino-agent-bridge.jstest/bridgederives every module the bridge loads, plus their relative requires, from the source. It fails ifextraResourcesdoesn't copy one of them, or if the layout breaks the relative require.Test plan
release.yml.resources/mcp-bridge/contains exactly the 5 files, each byte-identical to its source.app/pluginsis still packaged.tools/list,search_toolsandget_category_toolsall match the repo checkout's bridge exactly.lib/commonreturns an empty tool list and "not running" for discovery. This proves the packaged copy really loads its bundled modules.execute_tool arduino_contextreturnsmcp_version: 0.6.1.yarn test:bridge: 12/12 pass, including the new packaging guard.extraResourcesmechanism already shipsplugins/on all three platforms).🤖 Generated with Claude Code