Skip to content

✨fix: skip dev-bot local emoji import to avoid env side-effects #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Aug 23, 2026
Merged

✨fix: skip dev-bot local emoji import to avoid env side-effects #2977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/bottools/app_emoji.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
return EnsureEmojiFromLocalRepo(s, name)
})

EmoteMapNew := make(map[string]ei.Emotes)

Check failure on line 54 in src/bottools/app_emoji.go

View workflow job for this annotation

GitHub Actions / audit 

this value of EmoteMapNew is never used (SA4006)

Check failure on line 54 in src/bottools/app_emoji.go

View workflow job for this annotation

GitHub Actions / lint 

ineffectual assignment to EmoteMapNew (ineffassign)

Check failure on line 54 in src/bottools/app_emoji.go

View workflow job for this annotation

GitHub Actions / audit 

this value of EmoteMapNew is never used (SA4006)

Check failure on line 54 in src/bottools/app_emoji.go

View workflow job for this annotation

GitHub Actions / lint 

ineffectual assignment to EmoteMapNew (ineffassign)

fileInfo, err := os.Stat(emoteFilePath)
if force || err != nil {
Expand Down Expand Up @@ -106,11 +106,6 @@
}
}

// If running on dev bot, do not read or import missing emojis from local emoji/ directory
if config.IsDevBot() {
return ei.Emotes{}, false
}

// If still missing after Discord fetch, look up image in local emoji/ directory
emojiPath, ok := findLocalEmojiPath(emojiName)
if !ok {
Expand Down
Loading