Avoid unaligned writes in CPU RandomBits#3891
Open
markjouh wants to merge 1 commit into
Open
Conversation
markjouh
marked this pull request as ready for review
July 22, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RandomBitsimplementationmemcpyfor complete wordsRoot cause
For batched keys, each key's output begins
bytes_per_keybytes after theprevious one. When that stride is not divisible by four, casting the start of a
later key's output to
uint32_t*and writing through it is undefined behavior.The existing
test random bitscase covers an affected layout: vmapping fiveuint16values over two keys makes each per-key output 10 bytes wide. Beforethis change, that test aborts under UBSan with a misaligned
uint32_tstore.Validation
UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1 build-ubsan/tests/tests -tc='test random bits'(1 test, 28 assertions)clang-format --dry-run --Werror mlx/backend/cpu/primitives.cppgit diff --check