Fix prod dtype promotion when reducing a size-1 axis#3898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
prodcomputes its promoted output type but discards it on the no-op branch, so the result dtype depends on the length of the reduced axis. Reducing a size-1 axis returns the input dtype while a size-2 axis promotes:sumcasts on the same branch (is_noop ? astype(a, out_type, s) : ...), butprodreturned barea. The fix applies the sameastype, soprodmatchessumand the other promoting reductions. The promotion is there to keep the product from overflowing the narrow input type, so the size-1 case was also silently keeping a narrow accumulator.Added a test that the output dtype does not depend on the reduced axis length.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes