Refactor the JACCL ring and add threads for the multiple rings#3900
Open
angeloskath wants to merge 7 commits into
Open
Refactor the JACCL ring and add threads for the multiple rings#3900angeloskath wants to merge 7 commits into
angeloskath wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of the coordinator changes and I will rebase it when that is merged, for now focus on the changes in the reduction ops and more importantly the ring implementation.
The TL;DR is the following:
The performance on a single wire is maintained and there should be 0 overhead since that wire runs in the calling thread.
TODO: Add multi-wire benchmarks to show improved performance compared to before.