feat(metrics): report input sequence lengths - #442
Open
roborluo wants to merge 1 commit into
Open
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage ? 80.40%
=======================================
Files ? 149
Lines ? 20106
Branches ? 0
=======================================
Hits ? 16166
Misses ? 3940
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arekay-nv
reviewed
Aug 12, 2026
arekay-nv
left a comment
arekay-nv
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to go with the updated tests.
Can you also update the docs with the ISL updates.
Comment on lines
+235
to
+236
| assert report.input_sequence_lengths["min"] > 0 | ||
| assert set(report.input_sequence_lengths) == set(report.output_sequence_lengths) |
Collaborator
There was a problem hiding this comment.
Can we harden the test here to ensure that we are not mixing ISL and OSL metrics. Having min > 0 would not catch if we accidentally plug OSL stats into ISL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
input_sequence_lengthsto the performanceresult_summary.json.This exposes the existing ISL metric using the same full distribution
format as
output_sequence_lengths:What does this PR do?
Related to #439.
Expose the existing ISL metric as
input_sequence_lengthsin theperformance
result_summary.json, using the same full distribution format asoutput_sequence_lengths:Also render input sequence lengths in the terminal report.
Type of change
Related issues
Closes #439
Testing
uv run pytest tests/unit/metrics/test_report_builder.py tests/unit/ async_utils/services/metrics_aggregator/test_registry.pyChecklist
os.sched_setaffinity/os.sched_getaffinity.