Skip to content

Release workflow: skip the duplicate tag-push run and pin the App token action #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anandhu-eng merged 2 commits into from
Sep 29, 2026
Merged

Release workflow: skip the duplicate tag-push run and pin the App token action #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380f2d7
Skip the tag-push run started by a manual release; pin the App token …
anandhu-eng Sep 23, 2026
c119ba5
Update build_wheels.yml
anandhu-eng Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ concurrency:

jobs:
build_wheels:
if: github.repository_owner == 'mlcommons'
# A manual release pushes its tag with the App token, which starts this
Comment thread
anandhu-eng marked this conversation as resolved.
# workflow again; that run would rebuild and re-upload the same release. The
# below check ensures that does not happen
if: >-
github.repository_owner == 'mlcommons'
&& !(github.event_name == 'push' && github.actor == 'mlc-automations[bot]')
name: Build wheel
runs-on: ubuntu-latest
environment: release
Expand All @@ -47,7 +52,7 @@ jobs:
steps:
- name: Generate GitHub App token
Comment thread
anandhu-eng marked this conversation as resolved.
id: app-token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
app-id: ${{ secrets.MLC_AUTOMATIONS_APP_ID }}
private-key: ${{ secrets.MLC_AUTOMATIONS_PRIVATE_KEY }}
Expand Down
21 changes: 18 additions & 3 deletions tests/test_build_wheels_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,8 @@ def test_checkout_uses_app_token_for_protected_branch_pushes(self):
step for step in self.steps if step.get("uses", "").startswith("actions/checkout@")
)

self.assertEqual(
token_step["uses"],
"actions/create-github-app-token@v1")
self.assertTrue(
token_step["uses"].startswith("actions/create-github-app-token@"))
Comment thread
anandhu-eng marked this conversation as resolved.
self.assertEqual(
token_step["with"]["app-id"],
"${{ secrets.MLC_AUTOMATIONS_APP_ID }}",
Expand Down Expand Up @@ -116,6 +115,22 @@ def test_release_step_uses_app_token_for_github_release_mutations(self):
"${{ steps.app-token.outputs.token }}",
)

Comment thread
anandhu-eng marked this conversation as resolved.
def test_tag_push_from_app_token_does_not_start_second_release(self):
job_condition = self.workflow["jobs"]["build_wheels"]["if"]

self.assertIn("github.repository_owner == 'mlcommons'", job_condition)
self.assertIn(
"!(github.event_name == 'push' && github.actor == 'mlc-automations[bot]')",
job_condition,
)

def test_actions_are_pinned_to_commit_shas(self):
for step in self.steps:
uses = step.get("uses")
if uses:
ref = uses.split("@", 1)[1]
self.assertRegex(ref, r"^[0-9a-f]{40}$", uses)

def test_workflow_serializes_release_runs(self):
concurrency = self.workflow["concurrency"]

Expand Down
Loading