Skip to content

Document MLC_REPO_LOCK_TIMEOUT - #325

Open
anandhu-eng wants to merge 1 commit into
fix/pull-repo-no-destructive-cleanupfrom
docs/repo-lock-timeout
Open

anandhu-eng wants to merge 1 commit into
fix/pull-repo-no-destructive-cleanupfrom
docs/repo-lock-timeout

Conversation

@anandhu-eng

@anandhu-eng anandhu-eng commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Stack: #265 ← #323 ← #325 ← #326. Merge in that order: #323 into #265's branch first, then each next PR. This PR targets #323's branch.

#265 adds the MLC_REPO_LOCK_TIMEOUT environment variable (default 1800 s). The timeout error tells users to raise it, but nothing documented it.

Changes

  • mlc/repo_action.py: extends the comment next to REPO_LOCK_TIMEOUT_ENV, so the full behaviour is described where the variable is defined:
    • units (seconds, float) and the 1800 s default
    • which commands use it: pull repo and rm repo
    • fallback rules: unset or empty silently uses the default; non-numeric or ≤ 0 values also use the default, with a warning
    • when a timeout still counts as success
    • that it doesn't affect the 60 s repos.json lock
  • docs/targets/repo/index.md: adds one bullet to the Pull section's notes. It says pull waits while another process holds the repo, what the default is, and how to raise it.

Comment and docs only; no code changes. Unit tests pass locally (121).

🤖 Generated with Claude Code

@anandhu-eng
anandhu-eng requested a review from a team as a code owner September 23, 2026 22:38
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary

This PR adds documentation and code comments about the repo lock timeout behavior for the mlc pull repo action, introducing the MLC_REPO_LOCK_TIMEOUT environment variable to control how long the process waits for a repo lock before timing out. This improves clarity on concurrency handling and timeout configuration. No design issues or risks are apparent from the diff; the changes are purely informational and do not alter functionality.

@anandhu-eng
anandhu-eng force-pushed the docs/repo-lock-timeout branch from e306884 to 04f14aa Compare September 23, 2026 23:11
@anandhu-eng
anandhu-eng changed the base branch from copilot/fix-mlc-pull-repo-thread-safety to fix/pull-repo-no-destructive-cleanup September 23, 2026 23:11
@anandhu-eng
anandhu-eng added this pull request to stack #324 September 29, 2026 13:28
@anandhu-eng
anandhu-eng force-pushed the docs/repo-lock-timeout branch from 04f14aa to 9863df8 Compare September 29, 2026 13:52
Explain the variable's units, 1800 s default, fallback rules and timeout
semantics next to its definition, and add a short user-facing note to the
repo pull docs, since the timeout error tells users to raise it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@anandhu-eng
anandhu-eng force-pushed the docs/repo-lock-timeout branch from 9863df8 to 5d2142d Compare September 29, 2026 14:08

This branch was successfully deployed

1 active (outdated) deployment
ai-review — e306884e Deployed Sep 23, 2026 by anandhu-eng via ai-review #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant