BUG: use trial count for automatic CTPS threshold - #14279
Draft
AtomicGlance wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
ICA.find_bads_ecg(threshold="auto")now derives the CTPS threshold from the number of epochs actually supplied to CTPS, rather than from the recording sampling frequency. The threshold calculation is isolated in a small validated helper, and the documentation now describes the correct input.The regression test covers trial-count dependence, invalid counts, and verifies that the Raw/Epochs path passes the accepted epoch count through to the helper.
Tests run:
pytest -p pytest_cov mne/preprocessing/tests/test_ica.py -k "ctps_threshold_uses_trial_count or test_ica_additional" -qpytest -p pytest_cov mne/preprocessing/tests/test_ctps.py -qruff check mne/preprocessing/ica.py mne/preprocessing/tests/test_ica.pypython tools/check_changelog_names.pyI used Codex to help inspect the existing implementation and draft the regression test; I reviewed the resulting diff and ran the tests above. The statistical interpretation and final patch remain my responsibility.
This is a draft while the CTPS normalization details in issue #14267 are reviewed.