MRG: Avoid pytest 10 warnings in sklearn estimator checks - #14283
Open
Deepnar wants to merge 1 commit into
Open
Conversation
Deepnar
requested review from
agramfort,
drammock and
larsoner
as code owners
September 7, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #14277.
What does this implement/fix?
MNE's decoding estimator-compliance tests currently receive a generator-backed iterable from scikit-learn's
parametrize_with_checks. Pytest 10 deprecates passing non-collection iterables toparametrize, which produces warnings and can become an error.This change adds a local compatibility wrapper in
mne.decoding.teststhat materializes only the parametrized estimator values while preserving the surrounding pytest marks and their arguments. The affected decoding test modules use this wrapper, and the old warning suppression inmne/conftest.pyis removed.Additional information
Validation completed locally:
git diff --checkand AST parsing passed.This branch also includes the required Towncrier fragment and new-contributor entry.
AI assistance disclosure: Codex was used to inspect the repository and issue, plan the compatibility change, assist with implementation, and review the resulting diff. The submitted patch is accompanied by the local validation listed above; the author should review and understand every changed line.
Related commit:
81d4b379.