Conversation
Homebrew deprecates the `postflight` stanza; every brew command touching
the cask prints "Calling `postflight` is deprecated! Use
`postflight_steps` instead."
Convert to the declarative install-steps DSL: `on_macos` replaces the
`if OS.mac?` guard and `run` replaces `system_command`, with the
`{{staged_path}}` template token for the staged binary path. Verified
locally with `brew reinstall --cask mnemon`: no warning, quarantine
attribute stripped.
Note: this file is generated by GoReleaser; the durable fix is the
matching homebrew_casks change in mnemon-dev/mnemon (see
goreleaser/goreleaser#6870).
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Updates the generated Homebrew cask to replace deprecated postflight logic with the declarative install-steps DSL.
Changes:
- Uses
postflight_stepsandon_macos. - Runs
xattragainst{{staged_path}}.
File summaries
| File | Summary |
|---|---|
Casks/mnemon.rb |
Migrates quarantine removal to the current Homebrew DSL. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew now deprecates the
postflightcask stanza. Everybrewcommand that loads this cask prints:Change
postflight do … end→postflight_steps do … end, using the declarative install-steps DSL:on_macos do … endreplaces theif OS.mac?guard (evaluated at install time, same semantics).run "/usr/bin/xattr", args: […]replacessystem_command(fails the install on error, same as before).{{staged_path}}is the install-steps template token for the staged binary path.Verified
brew reinstall --cask mnemonon Homebrew 6.x with this cask: installs cleanly, prints no deprecation warning, and the quarantine attribute is stripped from the staged binary.Note
This file is generated by GoReleaser (
DO NOT EDIT), so the next release will regenerate it. The durable fix is the matchinghomebrew_caskschange in mnemon-dev/mnemon — until GoReleaser ships goreleaser/goreleaser#6873 (which addshooks.post.install_steps), the config-side fix usescustom_block. This PR fixes the warning for users in the meantime.