Repository navigation
fix(terminal): relay default foreground and background color queries - #1414
Closed
harryisfish wants to merge 1 commit into
Closed
harryisfish wants to merge 1 commit into
harryisfish wants to merge 1 commit into
Conversation
Forward OSC 10/11 read-only queries through synchronized query generations. Return terminal replies through the existing user input channel so TUIs can detect the local terminal palette without hardcoded colors.
Collaborator
|
We are not accepting LLM contributions at this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OSC 10/11 default-color queries are currently ignored. Applications such as OpenAI Codex use these replies to choose their theme; without them, Codex removes the input background and renders its startup animation with a reduced palette. Native SSH renders those elements correctly.
Relay exact read-only queries to the local terminal and return its replies through the existing user input channel. No colors are guessed or set.
Scope
Record separate foreground/background query generations in the framebuffer, synchronize their absolute values through an optional protobuf extension, and emit OSC 10/11 only in the actual client display. ANSI state serialization does not emit queries.
Blast Radius
Both client and server need this patch. Older peers ignore the extension and retain their current behavior. Multiple requests of the same kind within a display update are coalesced; pending requests can arrive after reconnect. This does not implement color setters or general OSC passthrough.
Verification
Related: #1145, #1351, #1333.