Remove SAM2 mask generation and SA-V support - #23
Conversation
Move SAM2HieraLarge promptable mask generation off main; the full implementation is preserved on the jm/sam branch. Removed: - mblt_vision.mask_generation (SAM2HieraLarge, prompt encoder port, graph contracts) and models/SAM2HieraLarge.yaml - the mask_generation task from VISION_TASKS and the top-level exports - SA-V dataset support: datasets/sa-v.yaml, CustomSAV, organize_sav, readiness checks, eval_sav, and benchmark/organize_sav.py - CLI point prompts, two-artifact path overrides, and SA-V val options - the mask_generation branch of Results - SAM/SA-V tests and documentation in the READMEs, AGENTS.md, and the mblt-vision skill Kept, as generic improvements that landed with the SAM work: wrapper.download_hub_artifact, _find_existing_source never returning the organized cache, the letterbox/postprocess fixes, MANIFEST.in, and the sample assets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
0.0.5 was never released, so the SAM removal ships as 0.0.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a6f8c1c66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The SAM cleanup cut the NYU Depth ranking rule out of AGENTS.md along with the adjacent SA-V bullets; restore it. Record the removal of the mask_generation surface (shipped in 0.0.3/0.0.4) as a breaking change in the Vision README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@mobilint-review Please re-review at 0a0dccc. Both earlier findings are addressed and resolved:
Guide for this review:
|
Summary
Removes SAM2HieraLarge promptable mask generation and SA-V dataset support from
main. The full implementation is preserved on thejm/sambranch (a snapshot ofmainat f8d8a07).Removed
mblt_vision.mask_generation(SAM2HieraLarge, prompt-encoder port, graph contracts) andmodels/SAM2HieraLarge.yamlmask_generationfromVISION_TASKSand the top-level exportsdatasets/sa-v.yaml,CustomSAV,organize_sav, readiness checks,eval_sav,benchmark/organize_sav.py--point, encoder/decoder/prompt-weights path overrides, and SA-Vvaloptions (predict.pyand_vision.pynow match their pre-SAM versions)mask_generationbranch ofResultsbenchmark/README.md,AGENTS.md, mblt-vision skill)Kept (generic improvements that landed with the SAM PR)
wrapper.download_hub_artifact_find_existing_sourcenever returning the organized cacheMANIFEST.in, sampleassets/Test plan
grep)ruff check --select F .clean,git diff --checkcleanlist_tasks()returns 8 taskspytest: 708 passed, 5 failed. All 5 aretests/test_onnx_yolo.pyHugging Face download failures (no network in the test environment); not rerun with network accessSets
__version__to0.0.5: 0.0.5 was never released, so this removal ships as 0.0.5.🤖 Generated with Claude Code