apparmor: validateProfile: avoid failures on unrelated STDERR output - #46
Merged
Merged
Conversation
This was failing if a non-fatal warning was printed on STDERR;
=== RUN TestGenerateProfileName
apparmor_linux_test.go:325: parsed profile names = ["Cache read/write disabled: interface file missing. (Kernel needs AppArmor 2.4 compatibility patch.)" "foo\"bar,*?[ab]{c,d}^\\baz"], want ["foo\"bar,*?[ab]{c,d}^\\baz"]
Use Cmd.Output when validating generated profiles so that warnings written to
stderr are not interpreted as declared profile names.
Preserve stderr from failed parser invocations in the test failure output.
updates aa2b3fd
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Sep 25, 2026
| cmd.Stdin = strings.NewReader(profile) | ||
|
|
||
| out, err := cmd.CombinedOutput() | ||
| out, err := cmd.Output() |
Member
Author
There was a problem hiding this comment.
🤦 I actually was considering this, then ... CI was happy and forgot about it 😂
Member
Author
|
@vvoland PTAL 🤗 |
vvoland
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was failing if a non-fatal warning was printed on STDERR;
Use Cmd.Output when validating generated profiles so that warnings written to stderr are not interpreted as declared profile names.
Preserve stderr from failed parser invocations in the test failure output.
updates aa2b3fd