Conversation
Member
|
Oh! I just merged the other one; I think we could consider keeping the golden one as well; it's there already, and the golden files allow easy asserting the profile all looks honky-dory as a whole. Adding the extra test probably is ok though. |
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
gen-special
branch
from
September 30, 2026 17:11
244e2a8 to
415d923
Compare
Contributor
Author
|
My concern is that this specific property shouldn't change based on what the apparmor profile itself restricts. |
thaJeztah
reviewed
Sep 30, 2026
Comment on lines
+349
to
+352
| got := profile.String() | ||
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| if !strings.Contains(got, tc.want) { |
Member
There was a problem hiding this comment.
But isn't this weaker than a .golden file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.