apparmor: allow compiling and testing on non-Linux - #49
Merged
Merged
Conversation
While AppArmor only applies to Linux platforms, the code in this module is largely platform-agnostic (with the exception of the apparmor utilities not being present). Remove the Linux build-tags to allow running the unit-tests on other platforms. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The platform-specific operations are appropriately guarded while portable functionality remains testable.
Review effort: Balanced
Findings: None
What changed in this PR
Enables the AppArmor package and its platform-agnostic tests to compile and run on non-Linux systems.
Changes:
- Removes the Linux build constraint from the AppArmor implementation.
- Adds portable unit tests while conditionally skipping Linux-specific integration checks.
| File | Description |
|---|---|
apparmor/apparmor.go |
Makes the implementation available across platforms. |
apparmor/apparmor_test.go |
Adds unit, integration, golden, and benchmark coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While AppArmor only applies to Linux platforms, the code in this module is largely platform-agnostic (with the exception of the apparmor utilities not being present).
Remove the Linux build-tags to allow running the unit-tests on other platforms.
With this patch: