[thaJeztah]

• depends on drop EOL go versions, update golang-ci-lint, gha #33
• depends on testing: use t.Cleanup() for test utilities, remove gotest.tools dependency #21
• depends on go.mod: github.com/creack/pty v1.1.18, golang.org/x/sys v0.1.0 #34

[thaJeztah]

Okay, moved this out of draft for consideration.

[thaJeztah]

Ah, I think this was the bit I was still looking at. It's somewhat unclear why x and y aren't exported; effectively WinSize in this module is identical to golang.org/x/sys/unix.Winsize`;

Type in this module:

// Winsize represents the size of the terminal window.
type Winsize struct {
	Height uint16
	Width  uint16
	x      uint16
	y      uint16
}

And in golang.org/x/sys:

type Winsize struct {
	Row    uint16
	Col    uint16
	Xpixel uint16
	Ypixel uint16
}

In this module, we're converting the types between, so perhaps instead we should make it an alias (and deprecate the local type). Let me look at that.

[thaJeztah]

Oh! I recall now; for Windows, it's a different type, so we can make it an alias (but only on !windows)

[thaJeztah]

Hm.. nevermind; field names are different 🤦

[Copilot]

🟢 Approval recommended

Static review found no blocking issues in this test-only refactor; tests were not executed.

No open issues 🎉

What changed in this PR

This test-only refactor moves the ASCII and escape-proxy tests to the external term_test package and simplifies existing test code without changing production behavior.

Changes:

• Rewrites TestEscapeProxyRead as a table-driven test while retaining existing scenarios.
• Uses exported APIs in the ASCII and escape-proxy tests.
• Simplifies Unix test cleanup and removes reliance on private window-size fields.

File	Description
term_unix_test.go	Simplifies cleanup and window-size initialization.
proxy_test.go	Converts escape-proxy tests to table-driven black-box tests.
ascii_test.go	Tests ToBytes through the exported package API.

_{Review effort: Balanced}