fix(ios): zip interoperability for server-side unzippers (#367)#371
Draft
plrthink wants to merge 6 commits into
Draft
fix(ios): zip interoperability for server-side unzippers (#367)#371plrthink wants to merge 6 commits into
plrthink wants to merge 6 commits into
Conversation
Expose listContents, unzipFiles, and unzipFilesWithPassword on iOS and Android so apps can inspect archives and extract only selected entries without switching to another library. Co-authored-by: Perry <plrthink@gmail.com>
Allow aborting in-flight zip/unzip work and reject with consistent ERR_* codes on iOS and Android, including ERR_CANCELLED. Co-authored-by: Perry <plrthink@gmail.com>
Honor STANDARD vs AES for file-array password zips, apply compression levels to file arrays, and fsync output so immediate uploads see full archives. Add a zip header validation script and README guidance. Co-authored-by: Perry <plrthink@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #367 (P1): make iOS-created ZIPs reliably consumable by common server unzippers.
Stacked on #370 (cancel/error codes) → #369 (listContents).
Fixes
zipFilesWithPasswordhonorsencryptionType(STANDARD→ ZipCrypto, AES-* → WinZip AES) instead of always writing AESscripts/validate-zip-header.jsAddresses the class of failures reported in #333 / #323 (iOS zip OK locally, fails in Node
unzipper/ JavaZipInputStream), especially AES-by-default password file arrays.Test plan
npm testnode scripts/validate-zip-header.json a sample archiveSTANDARDpassword and extract with NodeunzipperZipInputStream