Fix FFT cleaner aborting on already-stopped pools - #17
Open
cnnradams wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an FFT inference app has already been stopped,
modal app stopexits with status 1. The scheduled cleaner currently raises before deleting that pool's registry entry and aborts the remaining sweep. In a live run, this left ten abandoned inference pools deployed withmin_containers=1, even after their model/session records were reaped.Treat the CLI's explicit “App is already stopped.” response as successful cleanup, while preserving other errors. Isolate each pool's cleanup so a failing entry is logged and does not prevent later pools from being processed; unsuccessful stops keep their registry entries for retry.
Regression coverage checks already-stopped registry removal, normal stop success, propagation of other stop errors, and continuation/retry after a failed stop. Existing active-model and touch-during-stop coverage remains in place.
Validation:
uv run pytest -q tests/providers tests/control_plane(143 tests). No deployment or trainer configuration changes.