Skip to content

Update copilot-instructions.md: McpServerFactory was removed #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 3 commits into from
Oct 5, 2026
+5 −5
Merged

Update copilot-instructions.md: McpServerFactory was removed #1892

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b05c876
Update copilot-instructions to reference McpServer.Create instead of …
Zir0-93 Sep 26, 2026
412f0f1
Update copilot-instructions: drop three more removed names (McpEndpoi…
Zir0-93 Oct 4, 2026
dc86a74
Apply batched suggestions from code review
tarekgh Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ The SDK consists of three main packages:

### Naming Conventions
- Use `McpClient`, `McpServer`, `McpSession` for MCP-related classes (capitalize MCP)
- Prefix MCP-specific types with `Mcp` (e.g., `McpException`, `McpEndpoint`)
- Prefix MCP-specific types with `Mcp` (e.g., `McpException`, `McpServerOptions`)
- Use descriptive names for parameters with `[Description("...")]` attributes when exposing to MCP

## Architecture Patterns

### Dependency Injection
- Use Microsoft.Extensions.DependencyInjection patterns
- Register services with `.AddMcpServer()` and `.AddMcpClient()` extension methods
- Register the server with the `.AddMcpServer()` extension method
- Support both builder patterns and options configuration

### JSON Serialization
Expand All @@ -74,7 +74,7 @@ The SDK consists of three main packages:
- Set `JsonIgnoreCondition.WhenWritingNull` for optional properties to minimize payload size
- Use `JsonSerializerDefaults.Web` for camelCase property naming
- Protocol types are decorated with `[JsonSerializable]` attributes for AOT support
- Custom converters: `CustomizableJsonStringEnumConverter` for flexible enum serialization
- When reflection-based serialization is enabled, user-defined enums are serialized as strings with the built-in `JsonStringEnumConverter`; Native AOT enums require source-generated converter metadata such as `JsonStringEnumConverter<TEnum>`.

### Async Patterns
- All I/O operations should be async
Expand Down Expand Up @@ -246,7 +246,7 @@ Two primary transport implementations with different invariants:
- Default to `McpJsonUtilities.DefaultOptions` if not specified
- Can use reflection-based serialization or custom source generators

- **Enum handling**: `CustomizableJsonStringEnumConverter` for flexible enum serialization
- **Enum handling**: reflection-based serialization uses the built-in `JsonStringEnumConverter`; Native AOT enums require source-generated converter metadata such as `JsonStringEnumConverter<TEnum>`

## Architecture and Design Patterns

Expand All @@ -255,7 +255,7 @@ Two primary transport implementations with different invariants:
- **IMcpServerBuilder** pattern provides fluent API for configuring servers via DI
- Server primitives (tools, prompts, resources) are discovered via reflection using attributes
- Support both attribute-based registration (`WithTools<T>()`) and instance-based (`WithTools(target)`)
- Use `McpServerFactory` to create server instances with configured options
- Use `McpServer.Create` to create server instances with configured options

### Tool/Prompt/Resource Discovery
- Tools, prompts, and resources use attribute-based discovery: `[McpServerTool]`, `[McpServerPrompt]`, `[McpServerResource]`
Expand Down
Loading