Repository navigation
Conversation
er-s-an
marked this pull request as ready for review
October 12, 2026 12:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture the event listener snapshot before invoking the singular
on*handler. This makes mutations from that handler obey the same documented next-dispatch behavior as mutations fromaddEventListenerlisteners.Previously, an
on*handler that added a listener caused that new listener to receive the event already in progress. Removing a listener from the handler caused it to miss the current event. Both contradictedEventDispatcher.dispatch()'s documented snapshot contract. This affects the shared notification fan-out used by App and AppBridge.The fix preserves handler-first invocation and listener insertion order. The two regression tests verify both the current and subsequent dispatch.
Verification
bun test ./src/*.test.ts ./src/server/*.test.ts).tsc --noEmitpassed.git diff --checkpassed.listen EPERM); no successful build or browser/E2E run is claimed.bun test srcalso discovered a PDF example test without its workspace dependency@cantoo/pdf-lib; the scoped SDK suite above passes.AI assistance was used for diagnosis, implementation and test preparation. The change was checked against fresh local regression results; no remote model APIs were needed.