fix: treat relatedRequestId 0 as present in debounce guard - #2658
Closed
juneja-varun wants to merge 2 commits into
Closed
fix: treat relatedRequestId 0 as present in debounce guard#2658juneja-varun wants to merge 2 commits into
juneja-varun wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a81a911 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
The debounce guard used a truthiness check on options.relatedRequestId, so a related request id of 0 (a valid JSON-RPC id, and the first id a Protocol instance issues) was treated as absent and the notification was wrongly debounced. Switch to an explicit undefined check. Fixes modelcontextprotocol#2117
juneja-varun
force-pushed
the
fix/related-request-id-zero-debounce
branch
from
August 15, 2026 18:39
53d504b to
a81a911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The debounce guard in
_notificationViaCodecused a truthiness check onoptions?.relatedRequestId:0is a valid JSON-RPC request id — and the first id aProtocolinstance issues — but the truthy check treats it the same as "absent", so a notification related to request0gets silently coalesced by the debounce path even though related notifications are supposed to bypass debouncing.Fix
Switch to an explicit presence check (
!== undefined), matching how the rest of the codebase treats optional request ids.Testing
Added a regression test mirroring the existing "should NOT debounce a notification that has a relatedRequestId" case, but with
relatedRequestId: 0.pnpm --filter @modelcontextprotocol/core-internal exec vitest run test/shared/protocol.test.tspasses (40/40).Fixes #2117