fix(errors): forward SdkError causes onto Error.cause - #2666
Open
eddinos2 wants to merge 1 commit into
Open
Conversation
classifyNetworkError (and any site that passes `{ cause }` as the data
argument) left the underlying fetch/DNS error in `.data.cause`, so pino
and Sentry cause-chain walkers stopped at the SdkError and lost
ENOTFOUND vs ECONNREFUSED detail.
Peel a `cause` key out of the data bag into ErrorOptions, accept an
explicit options argument, and construct the negotiation failure with
`{ cause }` on ErrorOptions. Adds focused regression tests.
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Happy to adjust the peel heuristics if you'd rather keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SdkError third argument is
data, but classifyNetworkError passed{ cause }. That left the underlying fetch/DNS error on.data.causeinstead of.cause, so pino/Sentry cause-chain walkers lost ENOTFOUND vs ECONNREFUSED detail.{ cause }out of the data bag into ErrorOptionsoptions?: ErrorOptionson SdkError / SdkHttpError{ cause }Closes #2657
Test plan