fix: prevent stderr pipe deadlock in StdioClientTransport - #2803
Closed
KooshaPari wants to merge 1 commit into
Closed
fix: prevent stderr pipe deadlock in StdioClientTransport#2803KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
When stderr: 'pipe' is used and nobody attaches a reader, the pipe fills up, the child process blocks on write(2), and the session silently hangs — no error, no rejection, no timeout. Fixed by calling .resume() on the stderr PassThrough stream after piping, so it flows into the internal buffer and never blocks the child. A consumer that attaches a listener still gets the data; one that does not gets a working session instead of a hang.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2776