fix: cache compiled validators in AjvJsonSchemaValidator to prevent memory leak - #2806
Closed
KooshaPari wants to merge 1 commit into
Closed
fix: cache compiled validators in AjvJsonSchemaValidator to prevent memory leak#2806KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
…emory leak Fixes #2605. `getValidator()` called `this._ajv.compile(schema)` on every invocation for schemas without ``, which is the common case for MCP tool schemas. Each compilation is retained by Ajv's internal scope forever, causing unbounded heap growth in long-running clients that periodically refresh their tool catalogue. Adds a content-keyed cache (`Map<string, compiled>`) for schemas without ``. Schemas with `` continue to use Ajv's built-in cache. The cache compiles a fresh structural copy (`JSON.parse(key)`) to avoid stale results from Ajv's identity cache if a caller mutates the schema object in place. Adds 4 tests verifying caching behavior: duplicate calls produce consistent results, same-content schemas share validators, different schemas get different validators, and each unique schema compiles only once.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2605