feat: basic FMI3 CS doStep implementation - #415
Merged
Conversation
PeterMeisrimelModelon
force-pushed
the
dev-pm-480
branch
from
July 13, 2026 09:10
9457e55 to
ed767a4
Compare
PeterMeisrimelModelon
force-pushed
the
dev-pm-480
branch
from
August 10, 2026 12:37
d5e091d to
cd96a89
Compare
PeterMeisrimelModelon
force-pushed
the
dev-pm-480
branch
from
August 11, 2026 07:27
65bb534 to
aee97c1
Compare
efredriksson-modelon
requested changes
Aug 11, 2026
efredriksson-modelon
approved these changes
Aug 11, 2026
efredriksson-modelon
left a comment
Collaborator
There was a problem hiding this comment.
🍉
(but please consider tweaking the variable names 😄)
PeterMeisrimelModelon
force-pushed
the
dev-pm-480
branch
from
August 11, 2026 14:15
ea6cde5 to
1738313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really re-viewable commit-by-commit.
Test re-structuring:
conftest.pyand the relevant helper functions to the newutils.py.Comments for the actual changes:
terminateSimulation = True, even if instantiated withallowEarlyReturn=Falseterminatenow being part of thedo_stepsignature is a breaking change, so we need a new mechanism to handle this. I think the 3 possible ways are a class attribute (the current variant), a helper function that fulfills the same purpose as the attribute, or makedo_stephave multiple returns. Multiple returns might be most aligned with the underlying C-API behavior, but least consistent with FMI2, but then again, this is a breaking change. Looking for input/suggestions here.